-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address input bugs #122
Address input bugs #122
Conversation
Reviewer's Guide by SourceryThis PR addresses input bugs by changing the input type from "numeric" to "number" in the code and documentation. It also introduces a new "reset()" method to reset the component's value and validity state. Class diagram showing updated input components with reset functionalityclassDiagram
class BaseInput {
-Boolean icon
-Boolean disabled
-Boolean required
-String type
-String value
-String validity
+reset() void
+validate() void
}
class AuroFormValidation {
+reset(elem) void
+validate(elem) void
}
class AuroCheckbox {
-Boolean checked
-Boolean error
+reset() void
}
class AuroRadioGroup {
-Number index
-String value
+reset() void
}
class AuroSelect {
+reset() void
}
class AuroCombobox {
-String auroInputHelpText
+reset() void
+focus() void
}
BaseInput ..> AuroFormValidation : uses
note for BaseInput "Changed inputMode from 'numeric' to 'number'"
note for AuroFormValidation "Added reset() method"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
70bff16
to
0caba7e
Compare
e96a7eb
to
480c4e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, the disabled state colors are off from https://www.figma.com/design/VpUz89Ov6ImBpY5YvzYbZW/Auro-toolkit?node-id=3264-27509&m=dev (not sure if this is the latest design)
Per this design spec, the disabled colors are correct: The design spec linked in the previous comment is outdated. |
ab0c7a0
to
8845302
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
cef190d
to
516a7ba
Compare
c8cd386
to
5aef36e
Compare
9260b1b
to
31252ad
Compare
31252ad
to
7c26b17
Compare
1c28818
to
ad38165
Compare
ad38165
to
3cb5638
Compare
🎉 This PR is included in version 1.6.0-beta.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Before Submitting this pull request:
Development
sectionnote: all pull requests require at least one linked ticket
Ready For Review
, all ticket's linked underDevelopment
must have their status changed toReady For Review
as wellBy submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I have performed a self-review of my own update.
Summary by Sourcery
Add a
reset()
method to all form components to clear the value and validity state.New Features:
reset()
methods toauro-checkbox
,auro-checkbox-group
,auro-combobox
,auro-datepicker
,auro-input
,auro-radio
,auro-radio-group
, andauro-select
components. These methods reset the components to their initial states, clearing any user input and validation errors.Tests:
reset()
methods.