Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: New 'tertiary' variant #205

Merged
merged 3 commits into from
May 7, 2024
Merged

Conversation

fajar-apri-alaska
Copy link
Contributor

@fajar-apri-alaska fajar-apri-alaska commented Apr 25, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #204

Summary:

This PR is to provides 'tertiary' option for CTA-hyperlink per ticket #204.

  • add the new feature example to apiExamples
  • also update generateDocs script to fix the issue in macOS based machines

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Generator script update

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@fajar-apri-alaska fajar-apri-alaska self-assigned this Apr 25, 2024
@fajar-apri-alaska fajar-apri-alaska requested a review from a team as a code owner April 25, 2024 07:59
@fajar-apri-alaska
Copy link
Contributor Author

Hi team,
News are, the key token values are a bit different with the one from blueprints (still using --auro instead of --ds).
I tried to map out per the latest ones. But I'm still not sure since some value are a bit off by it looks after it is rendered on the browser. So if anything is a miss from my side, please tell me so.
Thanks.

Figma/Blueprint links:
#204 (comment)

@fajar-apri-alaska fajar-apri-alaska linked an issue Apr 25, 2024 that may be closed by this pull request
@blackfalcon
Copy link
Member

Hi team, News are, the key token values are a bit different with the one from blueprints (still using --auro instead of --ds). I tried to map out per the latest ones. But I'm still not sure since some value are a bit off by it looks after it is rendered on the browser. So if anything is a miss from my side, please tell me so. Thanks.

Figma/Blueprint links: #204 (comment)

@leeejune please take note that the Figma blueprint is still referencing --auro- versus --ds.

fajar-apri-alaska and others added 2 commits May 7, 2024 11:50
- add new feature example to apiExamples
- update generateDocs script to fix the issue in macOS based machines

Changes to be committed:
	modified:   apiExamples/cta-fluid.html
	modified:   apiExamples/cta-small.html
	modified:   apiExamples/cta.html
	modified:   demo/api.md
	modified:   docs/api.md
	modified:   package-lock.json
	modified:   scripts/generateDocs.mjs
	modified:   src/auro-hyperlink.js
	modified:   src/component-base.mjs
	modified:   src/style.scss
This commit updates all the legacy .is-touch selector references, that
was deprecated a while ago, to use the preferred @media hover query.

@include auro_anchorButton was also updated to use the `noncomponent`
API option. While this is inconsistent with intended use, the
`component` value of the API calls in the legacy .is-touch reference
that is no longer supported.

This is discussed in the following WCSS issue
AlaskaAirlines/WebCoreStyleSheets#192

Changes to be committed:
modified:   src/component-base.mjs
modified:   src/style.scss
@blackfalcon blackfalcon force-pushed the fajarapri/tertiaryVariant branch from 5efdf75 to 36d88bf Compare May 7, 2024 18:50
Changes to be committed:
modified:   package-lock.json
modified:   package.json
@blackfalcon blackfalcon force-pushed the fajarapri/tertiaryVariant branch from 36d88bf to 53370e5 Compare May 7, 2024 18:55
@blackfalcon blackfalcon merged commit 3492ed8 into main May 7, 2024
6 checks passed
@blackfalcon blackfalcon deleted the fajarapri/tertiaryVariant branch May 7, 2024 18:58
@blackfalcon
Copy link
Member

🎉 This PR is included in version 3.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auro-hyperlink: add tertiary option to CTA hyperlink
2 participants