feat(theme): update styles to support themeing #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jul 16, 2024
jason-capsule42
force-pushed
the
jbaker/betaWithTheme
branch
2 times, most recently
from
a848a04 to
6b900f7
Compare
jordanjones243
requested changes
Jul 16, 2024
There was a problem hiding this comment.
Obviously there needs to be review from design, but there were a number of places (and I did not look through every single token) where there are available tokens that use the correct name and value, but are not included. That needs to be fixed before we push this to design review and release a beta.
jason-capsule42
force-pushed
the
jbaker/betaWithTheme
branch
3 times, most recently
from
e5016af to
7d5ae74
Compare
jason-capsule42
force-pushed
the
jbaker/betaWithTheme
branch
from
7d5ae74 to
4415f39
Compare
jason-capsule42
force-pushed
the
jbaker/betaWithTheme
branch
from
4415f39 to
17e26f5
Compare
jason-capsule42
force-pushed
the
jbaker/betaWithTheme
branch
from
17e26f5 to
5c2236e
Compare
|
🎉 This PR is included in version 3.7.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #211
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team