-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using calendar to select date causes an error in the javascript console #238
Comments
This bug is coming from an implementation error in CleaveJS. What's happening is that the This error does not affect the functionality of the datepicker, but logs an error on something that is going on behind the scenes and what users will likely never see. This bug will be put on hold until we can talk about it during `finement and determine the best solution. |
What do you think about putting a |
That is a good idea, will do. |
Unable to consistently reproduce this error. In a phone meeting, @blackfalcon was NOT able to repro, but @jordanjones243 IS able to repro. There is a WARN in the code that references this issue. @jordanjones243 will take a stab to look into this a little more and report back findings. |
Maybe a link between these two issues, @jason-capsule42 will review. |
I believe this issue is tied to when datepicker is setting the input to an empty string and auro-input is trying to parse that using CleaveJS into a valid date. This isn't an issue with datepicker itself but rather with auro-input. We need to prevent our auto-formatting from trying to happen against empty strings. Moving this ticket auro-input. |
Describe the bug
When using the calendar to select a date and the input field is empty, we get an error in the javascript console of the developer tools.
To Reproduce
Steps to reproduce the behavior:
There is a suspicion that this is coming from auro-input and features related to auto formatting.
Expected behavior
When a user adds a new date to a date picker, there is no error.
Recommended action
Look into how dates are being passed to input and see where the conflict is with input and cleave.js formatting the date. When there is an issue discovered be sure to create a NEW issue with auro-input documenting this issue and link back this issue.
Exit criteria
This issue will be considered closed once there is a demonstrated use case that does not throw the error.
Screenshots
The text was updated successfully, but these errors were encountered: