Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auro Library incorrectly installed in devDependencies #36

Closed
chrisfalaska opened this issue Oct 7, 2024 · 0 comments · Fixed by #37
Closed

Auro Library incorrectly installed in devDependencies #36

chrisfalaska opened this issue Oct 7, 2024 · 0 comments · Fixed by #37
Assignees
@Patrick-Daly-AA @chrisfalaska
Labels
auro-lockup

Comments

@chrisfalaska
Copy link
Contributor

Please verify the version of auro-lockup you have installed

4.0.0

Please describe the bug

  1. Open package.json
  2. Note that "@aurodesignsystem/auro-library": "^2.8.0", is listed inside devDependencies

Reproducing the error

None

Expected behavior

To avoid issues when installing into projects, Auro Library needs to be listed as part of dependencies.

What browsers are you seeing the problem on?

No response

Additional context

First reported in AlaskaAirlines/WC-Generator#573

Exit criteria

  1. Auro Library listed in dependencies
  2. build runs correctly
  3. tests pass
@chrisfalaska chrisfalaska added Type: Bug Bug or Bug fixes not-reviewed Issue has not been reviewed by Auro team members auro-lockup labels Oct 7, 2024
@chrisfalaska chrisfalaska self-assigned this Oct 7, 2024
@jason-capsule42 jason-capsule42 removed Type: Bug Bug or Bug fixes not-reviewed Issue has not been reviewed by Auro team members labels Oct 7, 2024
chrisfalaska pushed a commit that referenced this issue Oct 7, 2024
fix: moves auro library to dependencies in package.json #36
caa0961
@chrisfalaska chrisfalaska mentioned this issue Oct 7, 2024
Merged
3 tasks
@chrisfalaska chrisfalaska linked a pull request Oct 7, 2024 that will close this issue
fix: moves auro library to dependencies in package.json #36 #37
Merged
3 tasks
chrisfalaska added a commit that referenced this issue Oct 8, 2024
@chrisfalaska
fix: moving Library out of peerDependencies #36
36ef59c
chrisfalaska pushed a commit that referenced this issue Oct 8, 2024
@chrisfalaska
fix: moves auro library to dependencies in package.json #36
2ef5f82
chrisfalaska added a commit that referenced this issue Oct 8, 2024
@chrisfalaska
fix: moving Library out of peerDependencies #36
837da39
blackfalcon pushed a commit that referenced this issue Oct 8, 2024
@semantic-release-bot
chore(release): 4.0.1 [skip ci]
5acb85c 
## [4.0.1](v4.0.0...v4.0.1) (2024-10-08)

### Bug Fixes

* moves auro library to dependencies in package.json [#36](#36) ([2ef5f82](2ef5f82))
* moving Library out of peerDependencies [#36](#36) ([837da39](837da39))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Patrick-Daly-AA Patrick-Daly-AA

@chrisfalaska chrisfalaska

Labels
auro-lockup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: moves auro library to dependencies in package.json #36 AlaskaAirlines/auro-lockup
3 participants
@jason-capsule42 @Patrick-Daly-AA @chrisfalaska