Revert WCSS version #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @jordanjones243 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -6,7 +6,7 @@ import logoStandard from '@alaskaairux/icons/dist/restricted/AS-200.mjs'; | |||
| import logoOneworld from '@alaskaairux/icons/dist/logos/oneworld.mjs'; | |||
| import AuroLibraryRuntimeUtils from '@aurodesignsystem/auro-library/scripts/utils/runtimeUtils.mjs'; | |||
|
|
|||
| var styleCss = css`:focus:not(:focus-visible){outline:3px solid transparent}.headerLinkBox{display:flex;text-decoration:none}.logoIcon{width:calc(var(--ds-size-800, 4rem)*2);padding-right:var(--ds-size-100, 0.5rem);border-right-width:1px;border-right-style:solid;margin-right:var(--ds-size-100, 0.5rem)}.oneworldLogo{display:flex;width:calc(var(--ds-size-500, 2.5rem) + .1rem);flex-direction:column;justify-content:center;padding-left:var(--ds-size-50, 0.25rem);margin-bottom:var(--ds-size-100, 0.5rem)}.headerTitle{display:flex;flex-direction:column;justify-content:center;padding-left:var(--ds-size-50, 0.25rem)}.headerTitle-title{padding-bottom:var(--ds-size-50, 0.25rem);font-size:var(--ds-size-400, 2rem);line-height:1}.headerTitle-tagline{padding-bottom:var(--ds-size-50, 0.25rem);line-height:1;text-transform:uppercase}`; | |||
| var styleCss = css`*,*:before,*:after{box-sizing:border-box}@media(prefers-reduced-motion: reduce){*,*:before,*:after{animation-duration:.01ms !important;animation-iteration-count:1 !important;transition-duration:.01ms !important}}*:focus-visible{outline:0}*:focus-visible{outline:0}:focus:not(:focus-visible){outline:3px solid transparent}.headerLinkBox{display:flex;text-decoration:none}.logoIcon{width:calc(var(--ds-size-800, 4rem)*2);padding-right:var(--ds-size-100, 0.5rem);border-right-width:1px;border-right-style:solid;margin-right:var(--ds-size-100, 0.5rem)}.oneworldLogo{display:flex;width:calc(var(--ds-size-500, 2.5rem) + .1rem);flex-direction:column;justify-content:center;padding-left:var(--ds-size-50, 0.25rem);margin-bottom:var(--ds-size-100, 0.5rem)}.headerTitle{display:flex;flex-direction:column;justify-content:center;padding-left:var(--ds-size-50, 0.25rem)}.headerTitle-title{padding-bottom:var(--ds-size-50, 0.25rem);font-size:var(--ds-size-400, 2rem);line-height:1}.headerTitle-tagline{padding-bottom:var(--ds-size-50, 0.25rem);line-height:1;text-transform:uppercase}`; | |||
There was a problem hiding this comment.
issue (code-quality): Use const or let instead of var. (avoid-using-var)
Explanation
`const` is preferred as it ensures you cannot reassign references (which can lead to buggy and confusing code). `let` may be used if you need to reassign references - it's preferred to `var` because it is block- rather than function-scoped.From the Airbnb JavaScript Style Guide
jason-capsule42
approved these changes
Oct 28, 2024
rmenner
approved these changes
Oct 28, 2024
|
🎉 This PR is included in version 4.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #40
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team