Skip to content

Commit

Permalink
perf: update popper.js install method
Browse files Browse the repository at this point in the history
This commit updates how the auro-popover element consumed the library
popper.js code to better support ESM/SSR development environments.

NOTE: This update does not 100% solve the issues we have with popper.js.
This version of the library is deprecated and the owners of it have
moved to a new platform, Floating UI.

This element will still require upgrading to either a new library tool
or support native popover browser support.

Changes to be committed:
modified:   src/auro-popover.js
modified:   src/popover.js
  • Loading branch information
janabimustafa authored and blackfalcon committed Mar 18, 2024
1 parent 7bd346e commit 6f0ebc4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/auro-popover.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { LitElement, html, css } from "lit";
// Import touch detection lib
import styleCss from "./style-css.js";

import Popover from "./popover";
import Popover from "./popover.js";

/**
* Popover attaches to an element and displays on hover/blur.
Expand Down
2 changes: 1 addition & 1 deletion src/popover.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

/* eslint-disable max-params */

import { createPopper } from '@popperjs/core/dist/esm/popper';
import { createPopper } from '@popperjs/core';

// build the component class
const popoverOffsetDistance = 18,
Expand Down

0 comments on commit 6f0ebc4

Please sign in to comment.