-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 217 #231
base: main
Are you sure you want to change the base?
feat: 217 #231
Conversation
Reviewer's Guide by SourceryThis pull request introduces a new optional attribute, Class diagram for updated auro-select componentclassDiagram
class AuroSelect {
+String value
+Boolean disabled
+Boolean noCheckmark
+Boolean displayValueProp
+String placeholder
-Object optionSelected
+handleOptionSelected()
+render()
}
note for AuroSelect "New displayValueProp attribute added"
class AuroMenuOption {
+String value
+String label
+Boolean selected
}
AuroSelect --> AuroMenuOption: contains
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
For context to the reviewers, Victor is a Slalom resource. He had some time and an idea on how to fix so I suggested he put up a PR on a possible solution. Up to you all to decide whether to accept but it would work as a fix for what my team needs. |
Alaska Airlines Pull Request
This pull request adds an optional attribute to the
<auro-select / >
component calleddisplayValueProp
to enable displaying thevalue
prop instead of the label text of the<auro-menuoption />
label.This solves some cases where users may need a more appropriate visual feedback that corresponds to the users cognitively more ergonomic way of selecting an option such as the example screenshot below for country codes. (User does not know what the country code is for their country because of course not! - so selecting their country by common name is more useful, however the display of the country code is also useful for brief verification feedback to the user).
Resolves: # (issue, if applicable)
Please refer to this original Issue #217
Summary:
Screenshots:
With no additional configuration (also as in before these changes) works as expected):
With the implementation of 'displayValueProp`:
Note: manually tested in Chrome and Firefox
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
New Features:
displayValueProp
attribute.