-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update markdown partial pathing to consume new auro lib #101 #102
Conversation
Reviewer's Guide by SourceryThis PR updates the file path references in markdown files to align with the new auro library structure. The changes primarily involve modifying relative path references in various markdown files and updating the auro-library dependency to version 3.0.1. Class diagram for updated file path referencesclassDiagram
class MarkdownFile {
+String path
}
class AuroLibrary {
+String version
}
MarkdownFile --> AuroLibrary : uses
note for MarkdownFile "Updated path references to align with new library structure"
note for AuroLibrary "Updated to version 3.0.1"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sun-mota - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 2 issues found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the bundler changes that fixes the unresolved dependencies issue during the build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After installing the repo and running npm run build
I receive this error:
> node ./node_modules/@aurodesignsystem/auro-library/scripts/build/generateDocs.mjs
Retrieving latest "/Users/Chris.Friedberg@alaskaair.com/Dev/auro-table/docTemplates/README.md" file...
Error writing file: /Users/Chris.Friedberg@alaskaair.com/Dev/auro-table/docTemplates/README.md, ENOENT: no such file or directory, open '/Users/Chris.Friedberg@alaskaair.com/Dev/auro-table/docTemplates/README.md'
Error copying file: /Users/Chris.Friedberg@alaskaair.com/Dev/auro-table/docTemplates/README.md, ENOENT: no such file or directory, copyfile '/Users/Chris.Friedberg@alaskaair.com/Dev/auro-table/docTemplates/README.md' -> '/Users/Chris.Friedberg@alaskaair.com/Dev/auro-table/README.md'
Error processing README.md: Error copying "/Users/Chris.Friedberg@alaskaair.com/Dev/auro-table/docTemplates/README.md" file to output /Users/Chris.Friedberg@alaskaair.com/Dev/auro-table/README.md
npm run build issue is resolved with the latest library version
🎉 This PR is included in version 3.1.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #101
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Bug Fixes:
Summary by Sourcery
Bug Fixes:
Summary by Sourcery
Bug Fixes: