Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node to version 22 and push to main #105

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Update node to version 22 and push to main #105

merged 1 commit into from
Dec 20, 2024

Conversation

jordanjones243
Copy link
Contributor

@jordanjones243 jordanjones243 commented Dec 20, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: # (issue, if applicable)

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Update Node.js to version 22.

Enhancements:

  • Update repository settings to use "main" as the default branch instead of "master".
  • Update conventional commit types to use imperative mood.

CI:

  • Update CI tests to use Node.js v20 and v22.

Deployment:

  • Update deployment workflow to use Node.js v22.

Documentation:

  • Update contributing guidelines, issue templates, and code of conduct.

@jordanjones243 jordanjones243 requested a review from a team as a code owner December 20, 2024 21:51
Copy link

sourcery-ai bot commented Dec 20, 2024

Reviewer's Guide by Sourcery

This pull request updates the project to use Node.js version 22 and changes the default branch from "master" to "main".

State diagram for PR workflow changes

stateDiagram-v2
    [*] --> IssueCreated
    IssueCreated --> ConsultTeam: Submit issue
    ConsultTeam --> StartWork: Team approves
    StartWork --> CreateBranch: Create feature branch
    CreateBranch --> Development: Work on changes
    Development --> Tests: Run tests
    Tests --> PRSubmission: Tests pass
    PRSubmission --> Review: Submit PR
    Review --> Merge: Approved
    Merge --> main: Merge to main branch
    main --> [*]

    note right of main
        Changed from 'master' to 'main'
    end note
Loading

File-Level Changes

Change Details Files
Updated Node.js version
  • Changed Node.js versions in test matrix from 18.x and 20.x to 20.x and 22.x
  • Updated Node.js version in setup-node action to 22.x
  • Updated Node.js engine version to ^20.x
Changed default branch to "main"
  • Updated default branch to main
  • Updated rebase instructions to use main branch
  • Updated release condition to check for main branch
  • Updated branch push and pull request triggers to use main branch
.github/settings.yml
.github/CONTRIBUTING.md
.github/workflows/testPublish.yml
.github/workflows/codeql.yml
Added conventional commit guidelines
  • Added Conventional Commits section to CONTRIBUTING.md
  • Added information about commit message format, prefixes, and commit types
.github/CONTRIBUTING.md
Updated issue templates
  • Added exit criteria section to feature request and general support issue templates
.github/ISSUE_TEMPLATE/feature_request.yml
.github/ISSUE_TEMPLATE/general-support.yml
Added publish demo workflow
  • Created a new workflow to publish the demo on pull requests to the main branch
.github/workflows/publishDemo.yml
Updated stale configuration
  • Added additional line breaks for readability in stale.yml
.github/stale.yml
Updated CODEOWNERS file
  • Updated CODEOWNERS file (no specific details provided)
.github/CODEOWNERS
Updated package-lock.json file
  • Updated package-lock.json file (no specific details provided)
package-lock.json
Updated pull request template
  • Removed extra line break in pull request template
.github/PULL_REQUEST_TEMPLATE.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

Surge demo deployment failed! 😭

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jordanjones243 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The Node version specification in package.json should be "node": "^20 || ^22" - the .x suffix is redundant when using the caret (^) operator.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@jordanjones243 jordanjones243 merged commit e9b99ee into main Dec 20, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants