Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move theming support from Beta to Master #84

Merged
merged 13 commits into from
Sep 30, 2024
Merged

Move theming support from Beta to Master #84

merged 13 commits into from
Sep 30, 2024

Conversation

jordanjones243
Copy link
Contributor

@jordanjones243 jordanjones243 commented Aug 16, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #82

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Move theming support from the Beta branch to the Master branch, introducing the ability to restyle the auro-table component using design tokens. Refactor the color token structure to improve consistency. Update documentation to reflect these changes.

New Features:

  • Introduce theme support for the auro-table component, allowing it to be restyled using design tokens.

Enhancements:

  • Refactor the color token structure to use tier 3 tokens for better consistency and maintainability.

Documentation:

  • Update documentation to include information on the new theme support feature, with examples of how to restyle the component using design tokens.

@jordanjones243 jordanjones243 requested a review from a team as a code owner August 16, 2024 15:38
@jordanjones243 jordanjones243 self-assigned this Aug 16, 2024
@jordanjones243 jordanjones243 linked an issue Aug 16, 2024 that may be closed by this pull request
2 tasks
@CLAassistant
Copy link

CLAassistant commented Aug 16, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ jordanjones243
✅ blackfalcon
❌ semantic-release-bot
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

sourcery-ai bot commented Aug 16, 2024

Reviewer's Guide by Sourcery

This pull request moves theming support from Beta to Master for the auro-table component. The changes include refactoring the color token structure with tier 3 tokens, adding theme support documentation, and updating the component to use new custom properties for styling. The update also includes some minor configuration changes and version updates.

File-Level Changes

Files Changes
demo/api.md
docs/partials/api.md
Added theme support documentation with SCSS variables for customization
src/style.scss
src/tokens.scss
Refactored color token structure to use tier 3 tokens
src/auro-table.js Updated component to import and use new token styles
tsconfig.json Updated TypeScript configuration for better compatibility
README.md Updated version number and CDN link in README
CHANGELOG.md Added new CHANGELOG entry for version 2.2.0-beta.1

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jordanjones243 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding test cases to verify the new theming functionality works as expected across different scenarios.
  • Update the version number in the README to reflect a stable release, rather than a beta version, if this is indeed moving to Master.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

src/style.scss Show resolved Hide resolved
jordanjones243 and others added 9 commits September 20, 2024 10:42
# [2.2.0-beta.2](v2.2.0-beta.1...v2.2.0-beta.2) (2024-09-20)

### Features

* add tag name as attribute when custom registered ([180be25](180be25))

### Performance Improvements

* refactor custom component registration config ([481b128](481b128))
* update build configurations and dependencies ([104882e](104882e))
BREAKING CHANGE: trigger major release for color theme support #82
# [3.0.0-beta.1](v2.2.0-beta.2...v3.0.0-beta.1) (2024-09-24)

### Performance Improvements

* update dependencies ([8d6b25a](8d6b25a))

### BREAKING CHANGES

* trigger major release for color theme support #82
@jason-capsule42 jason-capsule42 merged commit 3757f82 into master Sep 30, 2024
8 of 9 checks passed
@blackfalcon
Copy link
Member

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update color tokens for theming support
5 participants