Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drake/feature/modify uhf params via coms handler #65

Merged
merged 8 commits into from
Aug 13, 2024

Conversation

DrakBoul
Copy link
Contributor

modified simulated_uhf.py file to be able to recieve commands from coms handler. Currently, the only command the simulated uhf responds to is one that modifys the beacon message sent to the ground station.

Copy link
Member

@dheadrick1618 dheadrick1618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work! :) Minor change requested.

UHF/simulated_uhf.py Show resolved Hide resolved
@dheadrick1618
Copy link
Member

ALSO - Please change the host name to be explicitly the loopback address (127.0.0.1) - for some reason using the hostname returned by 'gethostname' on the socket object doesn't match the host name that the Rust Rocket server (that our GS backend is running on) uses.

@DrakBoul
Copy link
Contributor Author

ALSO - Please change the host name to be explicitly the loopback address (127.0.0.1) - for some reason using the hostname returned by 'gethostname' on the socket object doesn't match the host name that the Rust Rocket server (that our GS backend is running on) uses.

got it, I'll make those changes as soon as I can.

Copy link
Contributor

@rrasmuss4200 rrasmuss4200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to add a Usage section to the README? This would help future people testing and using it getting it up and running quickly. Just write about the clients that it expects and where it situates itself into the testing chain and such.

@DrakBoul
Copy link
Contributor Author

DrakBoul commented Aug 7, 2024

Are you able to add a Usage section to the README? This would help future people testing and using it getting it up and running quickly. Just write about the clients that it expects and where it situates itself into the testing chain and such.

Got it. I'll add that asap.

Copy link
Contributor

@rrasmuss4200 rrasmuss4200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good man. We should be able to incorporate this into our existing tall-thin architecture. Great work!

Copy link
Member

@dheadrick1618 dheadrick1618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

except OSError:
return False


def beacon(client, lock):
def mod_beacon(message, lock):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! Now I think the next step is to have the beacon period be modifiable.

@dheadrick1618 dheadrick1618 merged commit 3c3529a into main Aug 13, 2024
1 check passed
@DrakBoul DrakBoul deleted the drake/feature/modify_uhf_params_via_coms_handler branch August 23, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants