Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate RadioInterface class and the QML layout #5

Merged
merged 2 commits into from
Feb 15, 2017

Conversation

viktorgino
Copy link
Contributor

Hi

First of all: Great project, you've done exactly what I was about to do. Thanks ! 😄

In this PR I've included a few changes that'd allow the QML layout to be independent from the RadioInterface class.

Changed the called functions of RadioInterface from slots to public Q_INVOKABLE and call them directly from QML.
…terface

Appropriate changes have been made to the RadioInterface and QML files
@AlbrechtL AlbrechtL merged commit d27cf36 into AlbrechtL:master Feb 15, 2017
@AlbrechtL
Copy link
Owner

Hi,
Welcome to the welle.io development.
Thanks for the code review and the enhancements.

@AlbrechtL
Copy link
Owner

Did you test the changes under Windows?

Today I run it with Windows 10 and welle.io crashes immediately with a segfault after selection a station. The backtrace shows nonsense.

@viktorgino
Copy link
Contributor Author

I tested it on Ubuntu, but I'll try to run it on Windows soon

@viktorgino
Copy link
Contributor Author

Builds and runs nicely on Windows 10, built the latest master with MinGW5.3 and Qt5.7.1 using the libraries from https://github.com/AlbrechtL/welle.io-win-libs.git however I don't have sound. What does the backtrace show in Qt Creator?

@AlbrechtL
Copy link
Owner

I changed to sound output from portaudio to QMultimedia to reduce 3rd party lib dependency. Maybe something goes wrong on Windows. I will check this.

@AlbrechtL
Copy link
Owner

It was an issue on my side. Audio is now working under Windows.

AlbrechtL added a commit that referenced this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants