Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

New version of graphql (1.11.7) broke the build #59

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link

@depfu depfu bot commented Jan 19, 2021

We've tested your project with an updated dependency and the build failed.

This version is either within the version range you specified or you haven't specified a version/range. To be able to test your project with the new version, we've taken the liberty of pinning the version for this branch and pull request.

name version specification new version
graphql ~> 1.9 1.11.7

Unfortunately, we encountered failing tests after pinning. This means that this new version is not compatible with your project and the test failure will potentially also happen on fresh installs.

If you have correctly specified a semantic versioning version range, you should probably also file an issue with the upstream project as they might have released an update that's breaking SemVer rules, which is not cool. (But then again, not all projects explicitly follow SemVer)

We've left the pull request open for you to investigate this issue. Please don't merge it as is, because, again, we've pinned the version of graphql for this test run.

What changed?

✳️ graphql (~> 1.9 → 1.11.7) · Repo · Changelog

Release Notes

1.11.7 (from changelog)

Breaking changes

  • Incoming integer values are properly bound (as per the spec) #3206 To continue receiving out-of-bound integer values, add this to your schema's def self.type_error(err, ctx) hook:

    def self.type_error(err, ctx)
      if err.is_a?(GraphQL::IntegerDecodingError)
        return err.value # return it anyways, since this is how graphql-ruby used to work
      end
      # ...
    end

New features

  • Support Ruby 3.0 #3278
  • Add validation timeout option #3234
  • Support Prometheus custom_labels in GraphQLCollector #3215

Bug fixes

  • Handle GraphQL::UnauthorizedError in interpreter in from arguments #3276
  • Set description for auto-generated input: argument #3141
  • Improve performance of fields will merge validation #3228
  • Use Float graphql type for ActiveRecord decimal columns #3246
  • Add some custom methods to ArrayConnection #3238
  • Fix generated fields for types ending Connection #3223
  • Improve runtime performance #3217
  • Improve argument handling when extensions shortcut the defined resolve #3212
  • Bind scalar ints as per the spec #3206
  • Validate that input object names are unique #3205

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu
Copy link
Author

depfu bot commented Jan 21, 2021

Closed in favor of #60.

@depfu depfu bot closed this Jan 21, 2021
@depfu depfu bot deleted the depfu/check/graphql-1.11.7 branch January 21, 2021 22:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants