Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename element_type into name #13

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Rename element_type into name #13

merged 1 commit into from
Nov 6, 2020

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Nov 6, 2020

This is the name of the attribute in Alchemy core, so we should use that name as well.

This is the name of the attribute in Alchemy core, so we should
use that name as well.
@tvdeyen tvdeyen requested a review from mamhoff November 6, 2020 13:24
@tvdeyen tvdeyen merged commit 6745612 into main Nov 6, 2020
@tvdeyen tvdeyen deleted the rename-element_type branch November 6, 2020 14:22
tvdeyen added a commit that referenced this pull request Nov 6, 2020
- Add fixed\_elements relationship to element serializer [\#14](#14) ([tvdeyen](https://github.com/tvdeyen))
- Rename element\_type into name [\#13](#13) ([tvdeyen](https://github.com/tvdeyen))
- Only include errors mixin in production mode [\#12](#12) ([tvdeyen](https://github.com/tvdeyen))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants