Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Layout Pages Controller #2

Merged
merged 1 commit into from
May 9, 2020
Merged

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented May 8, 2020

Sometimes we need content pages, sometimes we need layoutpages. For an
API consumer, using the Ransack API for this (filter: { layoutpage_true: "1" }) is cumbersome and unintuitive. This adds a new
controller instead and limits the pages controller to content pages.

@mamhoff mamhoff requested a review from tvdeyen May 8, 2020 09:26
Sometimes we need content pages, sometimes we need layoutpages. For an
API consumer, using the Ransack API for this (`filter: {
layoutpage_true: "1" }`) is cumbersome and unintuitive. This adds a new
controller instead and limits the pages controller to content pages.
@mamhoff mamhoff force-pushed the add-layout_pages_controller branch from 8dcac60 to 37bee80 Compare May 8, 2020 09:27
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good 👍

@mamhoff mamhoff merged commit 1630e68 into production May 9, 2020
@mamhoff mamhoff deleted the add-layout_pages_controller branch May 9, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants