Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return all layoutpages regardless of publication status #24

Merged
merged 2 commits into from
Dec 9, 2020

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Dec 9, 2020

Layoutpages do not have publication dates since they are not routable and are always displayed in the context of another page.

We want to be able to override the base_page_scope w/o losing
the includes.
Layoutpages do not have publication dates since they are not
routable and are always displayed in the context of another page.
@tvdeyen tvdeyen requested a review from mamhoff December 9, 2020 08:06
Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@tvdeyen tvdeyen merged commit 86719a0 into main Dec 9, 2020
@tvdeyen tvdeyen deleted the load-unpublished-layoutpages branch December 9, 2020 13:55
@pelargir
Copy link
Collaborator

pelargir commented Dec 9, 2020

Very nice. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants