Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include deprecated elements and essences #26

Merged
merged 2 commits into from
Jan 18, 2021

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jan 14, 2021

Like with non-public and trashed elements we do not want to include deprecated elements (a new feature in Alchemy 5.2) with the public API responses.

@tvdeyen tvdeyen force-pushed the add-deprecated-element-flag branch from eb09e0e to 7293d18 Compare January 14, 2021 14:41
@tvdeyen tvdeyen requested a review from mamhoff January 14, 2021 14:43
@tvdeyen tvdeyen marked this pull request as draft January 14, 2021 15:10
@tvdeyen tvdeyen self-assigned this Jan 14, 2021
@tvdeyen tvdeyen removed the request for review from mamhoff January 14, 2021 15:10
@tvdeyen tvdeyen force-pushed the add-deprecated-element-flag branch from 2670cdf to 4de1dc7 Compare January 18, 2021 14:46
Like with non-public and trashed elements we do not want
to include deprecated elements (a new feature in Alchemy 5.2)
with the public API responses.
@tvdeyen tvdeyen force-pushed the add-deprecated-element-flag branch from 4de1dc7 to b885f52 Compare January 18, 2021 15:49
@tvdeyen tvdeyen changed the title Add deprecated attribute to element serializer Do not include deprecated elements and essences Jan 18, 2021
@tvdeyen tvdeyen marked this pull request as ready for review January 18, 2021 15:50
@tvdeyen tvdeyen requested a review from mamhoff January 18, 2021 15:50
@tvdeyen tvdeyen merged commit 768099e into main Jan 18, 2021
@tvdeyen tvdeyen deleted the add-deprecated-element-flag branch January 18, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants