Add deprecated attribute to elements and contents #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
approved these changes
Jan 19, 2021
This attrobute is a new feature that was introduced in Alchemy 5.2 We use the definition hash here instead of the Element#deprecated? method because we still support older versions of Alchemy and a hash simply returns nil for an unkown key
In Alchemy 5.2 contents can be deprecated. Since this is just a Hash key we can simply use it even for older versions of Alchemy
tvdeyen
force-pushed
the
re-add-deprecated-attribute
branch
from
f07af94 to
8f59fd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
deprecatedattribute to elements and essence serializers. This attribute has been introduced in Alchemy 5.2