Optimize elements loading #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
optimize-elements-loading
branch
from
743ff01 to
58758b3
Compare
mamhoff
reviewed
Jan 20, 2021
mamhoff
reviewed
Jan 20, 2021
tvdeyen
force-pushed
the
optimize-elements-loading
branch
from
58758b3 to
6a3f958
Compare
We will use these decorators to load the elements in an efficient way to avoid N+1 queries.
This helps to reduce DB queries while keeping the existing API
This reduces a DB request
tvdeyen
force-pushed
the
optimize-elements-loading
branch
from
6a3f958 to
7aa6218
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimizes loading of elements by introducing decidated models that uses ruby methods to filter elements by attributes instead of using the database. This allows to preload
all_elementsat once and reduces DB queries a lot.co-authored by @mamhoff