Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix factory loading #39

Merged
merged 2 commits into from
Feb 17, 2021
Merged

Fix factory loading #39

merged 2 commits into from
Feb 17, 2021

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Feb 17, 2021

No description provided.

Alchemy 5.2 changed the way we load FactoryBot factories.
This file has been copy-pasted from Alchemy and the file
excluded is not present in this gem.
@tvdeyen tvdeyen requested a review from mamhoff February 17, 2021 12:17
@tvdeyen
Copy link
Member Author

tvdeyen commented Feb 17, 2021

@mamhoff the failing specs are related to

a) A new version of json-api adding new keys to the pagination result
b) In Alchemy v6 the element trash has been removed

I will provide individual PRs for each for easier changelog maintenance.

@tvdeyen tvdeyen merged commit 8a4c74d into main Feb 17, 2021
@tvdeyen tvdeyen deleted the fix-factory-loading branch February 17, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant