Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tests for trashed elements #40

Merged
merged 2 commits into from
Feb 18, 2021
Merged

Remove tests for trashed elements #40

merged 2 commits into from
Feb 18, 2021

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Feb 17, 2021

Alchemy 6 removes this feature and in old versions it is deprecated

@tvdeyen
Test for Alchemy 5.2 as well
fd2d883
@tvdeyen
Remove tests for trashed elements
6d92893 
Alchemy 6 removes this feature and in old versions it is
deprecated
@tvdeyen tvdeyen requested a review from mamhoff February 17, 2021 12:40
mamhoff
mamhoff approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Please merge both PRs, then the specs will be green again!

@tvdeyen tvdeyen merged commit d004e3c into main Feb 18, 2021
@tvdeyen tvdeyen deleted the alchemy-6-fixes branch February 18, 2021 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamhoff mamhoff mamhoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tvdeyen @mamhoff