Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ancestors relationship to page serializer #49

Merged
merged 2 commits into from
Apr 27, 2021
Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Apr 27, 2021

Useful if you want to serialize the page categorizations in a breadcrumb for instance.

tvdeyen added 2 commits April 27, 2021 12:30
The former named argument was misleading as it did not reflected
the page version, but a symbol of the type of version we want
to use from the Alchemy::Page.

As we want to expose the page_version_type, so we can use it and
pass on to new instances we needed to clarify.
Useful if you want to serialize the page categorizations
in a breadcrumb for instance.
@tvdeyen tvdeyen requested a review from pelargir April 27, 2021 11:42
Copy link

@rmparr rmparr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@tvdeyen tvdeyen removed the request for review from pelargir April 27, 2021 12:19
@tvdeyen tvdeyen merged commit 8018b56 into main Apr 27, 2021
@tvdeyen tvdeyen deleted the page-for-element branch April 27, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants