Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return image mime type with srcset responses #59

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Return image mime type with srcset responses #59

merged 1 commit into from
Mar 28, 2022

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Mar 28, 2022

If you want to pass the image type to a <picture> <source> element you need to set the type as well.

@tvdeyen
Return image mime type with srcset responses
f979c68 
If you want to pass the image type to a <picture> <source>
element you need to set the type as well.
@tvdeyen tvdeyen requested a review from mamhoff March 28, 2022 12:31
mamhoff
mamhoff approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tvdeyen tvdeyen merged commit 61a78fd into main Mar 28, 2022
@tvdeyen tvdeyen deleted the add-type-to-picture-serializers branch March 28, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamhoff mamhoff mamhoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tvdeyen @mamhoff