Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix page search #71

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Fix page search #71

merged 1 commit into from
Jul 18, 2023

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jul 18, 2023

We overwrote ransackable_attributes to only include page_layout and urlname,
but Alchemy needs name as well.

Fixed by adding page_layout to already defined ransackable_attributes.

@tvdeyen
Fix page search
7635b71 
We overwrote ransackable attributes to only include page_layout
and urlname, but Alchemy needs name as well. Fixed by adding
page_layout to already defined ransackable attributes.
@tvdeyen tvdeyen requested a review from a team July 18, 2023 07:37
@tvdeyen tvdeyen enabled auto-merge July 18, 2023 07:38
mamhoff
mamhoff approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops :)

@tvdeyen tvdeyen merged commit 92dbf57 into main Jul 18, 2023
@tvdeyen tvdeyen deleted the fix-page-search branch July 18, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamhoff mamhoff mamhoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tvdeyen @mamhoff