Autoload decorators #116
Draft
Autoload decorators #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a world where decorators are managed with Zeitwerk, we want to make sure the naming of our decorators does not conflict with the naming of decorators in other gems.
If our namespace should be Alchemy::Solidus, then let's rename this file, too.
mamhoff
commented
Nov 21, 2024
app/decorators/controllers/alchemy/solidus/spree_admin_base_controller_decorator.rb
Outdated
Show resolved
Hide resolved
mamhoff
force-pushed
the
autoload-decorators
branch
from
b85f24d to
705a799
Compare
We don't need to keep a whole file for a single line of ActionView configuration.
mamhoff
force-pushed
the
autoload-decorators
branch
from
705a799 to
c9473a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all the patches to core Solidus or the main app to places where they will be picked up by solidus_support.