Fixes for Solidus 2.5 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using deface we use the Solidus backend configuration to add a menu tab
If a store does not use solidus_frontend it does not have a root route, but Solidus > 2.5 expects to have one. This generator is generally a nice feature and fixes a bug in the dummy app, that does not have solidus_frontend installed
askl56
approved these changes
Sep 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some issues with Solidus 2.5
Mainly the bug with stores not having
solidus_frontendinstalled get a routing error insolidus_backendbecause thespreerouting proxy does not have theroot_urlmethod defined.Then we use the backend configuration to add the menu tab into solidus admin, since Solidus does not require Deface per default and we do not want to either.
Also adds a admin user generator, because the default Alchemy admin signup does not work with Solidus, as it brings its own admin users controller that loads before alchemy-devises admin users controller, if mounted before Alchemy (what it usually does).