Match path fix for tabs in Solidus < 2.8 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelargir
force-pushed
the
add-match-path
branch
2 times, most recently
from
0952909 to
26e806c
Compare
tvdeyen
reviewed
Aug 9, 2019
pelargir
force-pushed
the
add-match-path
branch
from
26e806c to
3da8aab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the "CMS" menu item in Solidus so that it doesn't appear open/selected when the "Users" page in the admin backend is active (see screenshot below).
This is accomplished by patching Solidus to enable the
match_pathoption to be passed into the CMSMenuIteminstance.Because Solidus 2.8 already supports the
match_pathoption, theMenuIteminitializer patch and tab partial are conditionally loaded for versions of Solidus less than 2.8.I've manually tested these changes against the CS app (Solidus 2.4) and it works as expected.
Before
After