Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require at least Alchemy 4.1 and Solidus 2.6 #45

Merged
merged 3 commits into from
Aug 9, 2019
Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Aug 9, 2019

Alchemy 4.1 only works with Solidus 2.6 because of incompatible dependencies (ransack and cancancan).

Since Solidus 2.5 and below are EOL anyways this is an accetable change.

@tvdeyen tvdeyen added this to the 2.4 milestone Aug 9, 2019
tvdeyen added 2 commits August 9, 2019 18:37
Alchemy 4.1 only works with Solidus 2.6 because of incompatible
dependencies (ransack and cancancan).

Since Solidus 2.5 and below are EOL anyways this is an accetable
change.
We want to test Solidus 2.9 and a newer Ruby version.
Like with Solidus we want to test all supported Alchemy versions
as well.
@tvdeyen tvdeyen merged commit d4dbef1 into master Aug 9, 2019
@tvdeyen tvdeyen deleted the alchemy-4.1 branch August 9, 2019 20:30
@tvdeyen tvdeyen mentioned this pull request Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant