Use non-animiated PNG. #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the icon was borrowed from the favicon on the Solidus site. The `ico` format can actually store several images at different resolutions. When automatically converting it turned these different images into different frames on an animated PNG. Not all browsers support it but if you view the icon in Firefox you will see it. This fixes this by just grabbing the 32x32 image and resizing that down to 24x24 to follow the same size as the previous Spree image.
|
Nice catch. Thanks for fixing |
|
Indeed thanks for fixing this! Was about to submit an issue. It is driving me crazy as it has also started to happen in Chrome : ) Will see to upgrade our project to a version containing this fix as I've been manually finding and deleting the icon to get rid of the animation : ) Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the icon was borrowed from the favicon on the Solidus site. The
icoformat can actually store several images at different resolutions.When automatically converting it turned these different images into different
frames on an animated PNG. Not all browsers support it but if you view the
icon in Firefox you will see it.
This fixes this by just grabbing the 32x32 image and resizing that down to
24x24 to follow the same size as the previous Spree image.