Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update automated installer #57

Merged
merged 9 commits into from
Dec 17, 2019
Merged

Update automated installer #57

merged 9 commits into from
Dec 17, 2019

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Dec 17, 2019 •
edited
Loading

A mayor overhaul of the installer

  1. It installs and runs the Alchemy migrations
  2. It does not install an alchemy.rb initializer into the host app anymore. We handle necessary config in the engine instead. Please make sure to remove the Alchemy::Modules.register_module part from your config/initializer/alchemy.rb file if upgrading
  3. Fixes the root route injection
  4. Generates a home page if Alchemy should handle the root route to remove confusion of an empty page for new comers.

Closes #54

@tvdeyen
Install solidus_frontend during tests
fc4c27b 
Out of sudden the admin integration spec fails because
the `spree.root_path` is not available anymore.

Weirdly enough the `respond_to?` should guard this, but it is not
working. Rails magic \o/
@tvdeyen
Use defined? instead of Kernel.const_defined? in installer
7c9cfe8 
The former does not work very well with spring and other app
preloaders.
@tvdeyen
Run the Alchemy migrations during automated install
01add99 
We obviously need the database tables.
@tvdeyen
Fix the root route question during install
d344be9
@tvdeyen
Fix the root route mount point
883ca3b 
Drawing the root path into the Solidus engine routes does not work.
@tvdeyen
Remove alchemy initializer creation during install
c798c25
@tvdeyen
Set Alchemy user if Solidus::Auth::Devise is used
18c39c4 
w/o that we cannot authenticate
@tvdeyen
Add a home page if Alchemy should serve the root route.
732a7ba 
Otherwise new users get a 404 and will be confused.
@tvdeyen
Update README for new installer
cf73106
@tvdeyen tvdeyen merged commit 997ecf0 into AlchemyCMS:master Dec 17, 2019
@tvdeyen tvdeyen deleted the update-installer branch December 17, 2019 13:28
This was referenced Dec 17, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automated install fails on existing Solidus install
1 participant
@tvdeyen