Build fixes #62
Merged
Build fixes #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason creating a user with Spree::Roles fails, and this little trick fixes it.
Previously, these only included the `EssencesHelper`. However, the method `content_name` is defined in the `Alchemy::ContentsHelper`. Including the `Alchemy::ElementsHelper` gets us both helpers, fixing the issue.
Let's support 3 versions and master.
mamhoff
force-pushed
the
build-fixes
branch
3 times, most recently
from
c218793 to
cd0fcb1
Compare
We support Rails 5.2 upwards.
The Solidus install generator from 2.8 onwards does not insert mounting the Solidus engine, it only adds a comment. The Alchemy generator inserts this only if it's not already here. The safest option is to simply have all the things in our routes.rb file.
Alchemy-Devise takes care of its own compatibility.
tvdeyen
approved these changes
May 29, 2020
tvdeyen
added a commit
that referenced
this pull request
Jun 11, 2020
- Ignore .ruby-version [\#63](#63) ([mamhoff](https://github.com/mamhoff)) - Build fixes [\#62](#62) ([mamhoff](https://github.com/mamhoff))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the install generator (require the correct file from Alchemy 5, and fix a bizarre validation error when creating the admin user) and includes the correct view helper in our view specs.
It also fixes the branch of
alchemy-deviseto always bemaster. Alchemy Devise doesn't do a lot, and importantly runs specs for the past three Alchemy versions on its own.We also upgrade the Travis image to Ubuntu 18.04 for an up-to-date node version.