Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add has_many folded_pages association to Spree::User #67

Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Aug 5, 2020

Rails 6 checks on the reverse association being present.

tvdeyen added 2 commits August 5, 2020 18:22
Rails 6 checks on the reverse association being present.
@tvdeyen tvdeyen requested a review from mamhoff August 5, 2020 16:32
Copy link

@BenAkroyd BenAkroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@BenAkroyd
Copy link

bah, looks like specs are failing- The file /home/travis/build/AlchemyCMS/alchemy-solidus/spec/dummy/db/seeds.rb does not appear to exist

This will be added by the solidus installer and causes issues with the latest versions of solidus.
@tvdeyen
Copy link
Member Author

tvdeyen commented Aug 5, 2020

bah, looks like specs are failing- The file /home/travis/build/AlchemyCMS/alchemy-solidus/spec/dummy/db/seeds.rb does not appear to exist

@BenAkroyd the problem was something else. I fixed it.

@tvdeyen tvdeyen merged commit 710acd8 into AlchemyCMS:master Aug 5, 2020
@tvdeyen tvdeyen deleted the add-reverse-association-folded-pages branch August 5, 2020 20:31
@tvdeyen tvdeyen removed the request for review from mamhoff August 5, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants