Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Alchemy 6 #85

Merged
merged 8 commits into from
Apr 27, 2022
Merged

Test Alchemy 6 #85

merged 8 commits into from
Apr 27, 2022

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Apr 26, 2022

Adds Alchemy v6.0 to test matrix.

NOTE: If you are using Solidus v3.0 with Alchemy v5.3, make sure to also use Rails v6.0 and the legacy image attachment adapter (paperclip) and not the active storage adapter, since this needs Rails >= 6.1 and Alchemy v5.3 is not Rails 6.1 compatible. You need Alchemy v6.0 for Rails >= 6.1.

@tvdeyen tvdeyen force-pushed the test-alchemy-6 branch 2 times, most recently from 7f0a29e to 3d6c12f Compare April 26, 2022 18:45
tvdeyen added 4 commits April 26, 2022 21:12
Loading factories the new way is not compatible with Solidus 2.10 and Alchemy 5.3

Since Solidus 2.10 is out of support it should be fine to run test for it.
tvdeyen added 2 commits April 26, 2022 21:29
They renamed the install task
Alchemy 5.3 is not compatible to Rails 6.1, but Solidus 3.0
needs Rails 6.1 if the default image attachment adapter (Active
Storage) is used. This is the case on CI. Let's skip that build.

If you want to use Alchemy 5.3 and Solidus v3.0, make sure to use
Rails 6.0 and the legacy image attachment adapter (Paperclip)
@tvdeyen tvdeyen merged commit 4f020f2 into AlchemyCMS:main Apr 27, 2022
@tvdeyen tvdeyen deleted the test-alchemy-6 branch April 27, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant