-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Alchemy 7 support: Remove custom essences #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
drop-alchemy-6-support
branch
2 times, most recently
from
March 17, 2023 18:14
4dd4dec
to
984627d
Compare
tvdeyen
force-pushed
the
drop-alchemy-6-support
branch
from
March 30, 2023 09:32
984627d
to
b061b27
Compare
tvdeyen
changed the title
Drop Alchemy 6 support: Remove custom essences
Add Alchemy 7 support: Remove custom essences
Mar 30, 2023
tvdeyen
force-pushed
the
drop-alchemy-6-support
branch
from
March 30, 2023 09:44
b061b27
to
b75f675
Compare
Alchemy 7 dropped support for essences.
- Remove Alchemy 6 and Solidus 2 builds - Adds Ruby 3.1, 3.2 and Solidus 3.2, 3.3 builds
Necessary for Rails 6.1 and 7.0
tvdeyen
force-pushed
the
drop-alchemy-6-support
branch
2 times, most recently
from
March 30, 2023 14:55
e8e57d4
to
a1311a2
Compare
Necessary for Alchemy 7
tvdeyen
force-pushed
the
drop-alchemy-6-support
branch
2 times, most recently
from
March 31, 2023 08:54
f7a5860
to
ae75283
Compare
tvdeyen
force-pushed
the
drop-alchemy-6-support
branch
from
March 31, 2023 13:29
69d6cff
to
25548d7
Compare
mamhoff
approved these changes
Mar 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops support for Alchemy 6