Remove responders gem

We don't need a gem for responding with JSON from a Rails controller.
AlchemyCMS · May 28, 2024 · 71ffa5d · 71ffa5d
1 parent 98293af
commit 71ffa5d
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 5 deletions.
diff --git a/alchemy_cms.gemspec b/alchemy_cms.gemspec
@@ -46,7 +46,6 @@ Gem::Specification.new do |gem|
   gem.add_runtime_dependency "kaminari", ["~> 1.1"]
   gem.add_runtime_dependency "originator", ["~> 3.1"]
   gem.add_runtime_dependency "ransack", [">= 1.8", "< 5.0"]
-  gem.add_runtime_dependency "responders", [">= 2.0", "< 4.0"]
   gem.add_runtime_dependency "sassc-rails", ["~> 2.1"]
   gem.add_runtime_dependency "simple_form", [">= 4.0", "< 6"]
   gem.add_runtime_dependency "sprockets", [">= 3.0", "< 5"]

diff --git a/app/controllers/alchemy/api/base_controller.rb b/app/controllers/alchemy/api/base_controller.rb
@@ -3,7 +3,6 @@
 module Alchemy
   class Api::BaseController < Alchemy::BaseController
     layout false
-    respond_to :json
 
     rescue_from CanCan::AccessDenied, with: :render_not_authorized
     rescue_from ActiveRecord::RecordNotFound, with: :render_not_found

diff --git a/app/controllers/alchemy/api/elements_controller.rb b/app/controllers/alchemy/api/elements_controller.rb
@@ -37,7 +37,7 @@ def index
     def show
       @element = Element.where(id: params[:id]).includes(*element_includes).first
       authorize! :show, @element
-      respond_with @element
+      render json: @element, serializer: ElementSerializer
     end
 
     private

diff --git a/app/controllers/alchemy/api/pages_controller.rb b/app/controllers/alchemy/api/pages_controller.rb
@@ -43,7 +43,7 @@ def nested
     #
     def show
       authorize! :show, @page
-      respond_with @page
+      render json: @page, serializer: PageSerializer
     end
 
     def move

diff --git a/lib/alchemy_cms.rb b/lib/alchemy_cms.rb
@@ -17,7 +17,6 @@
 require "kaminari"
 require "non_stupid_digest_assets"
 require "ransack"
-require "responders"
 require "sassc-rails"
 require "simple_form"
 require "turbo-rails"