Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove display cancan alias (3.6-stable) #1318

Merged
merged 2 commits into from
Oct 24, 2017

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Oct 23, 2017

The display cancan alias is also defined by Spree/Solidus. And because
Spree/Solidus clear all pre defined aliases in their Ability class it can
happen that our alias is not working anymore. Their alias is then used
instead.

The `display` cancan alias is also defined by Spree/Solidus. And because Spree/Solidus clear all pre defined aliases in their Ability class it can happen that our alias is not working anymore. Their alias is then used instead.

As we actually do not need this alias anywhere except in the permissions definition we can just remove it.
The `:show`, `:thumbnail` and `:zoom` `Alchemy::Picture` cancan permissions are not used anywhere since we removed the frontend pictures controller in v3.5
@tvdeyen tvdeyen merged commit 923d79d into AlchemyCMS:3.6-stable Oct 24, 2017
@tvdeyen tvdeyen deleted the remove-display-alias-3.6 branch October 24, 2017 12:06
tvdeyen added a commit that referenced this pull request Oct 24, 2017
- Remove `:display` cancan alias [#1318](#1318)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants