Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More admin cleanup #1343

Merged
merged 4 commits into from
Jan 16, 2018
Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jan 15, 2018

Follow up to #1339 with more clean up and refining the admin.

  • Removing the pleaseWait overlay from GET links
  • Use Turbolinks.visit for redirecting from Javascript
  • Remove unused contents controller actions

Instead of making a full page reload in cases we want to redirect with javascript we use Turbolinks.visit
All links that are normal GET requests do not need the pleaseWait
overlay. This is meant for actions with side effects, aka. POST
requests. By removing this we get much snappier navigation in the admin.
This is a leftover from "available contents" feature removal.
@tvdeyen tvdeyen merged commit fe97880 into AlchemyCMS:master Jan 16, 2018
@tvdeyen tvdeyen deleted the even-more-admin-cleanup branch January 16, 2018 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants