Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New table styles #1344

Merged
merged 4 commits into from
Jan 18, 2018
Merged

New table styles #1344

merged 4 commits into from
Jan 18, 2018

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jan 16, 2018

Builds on top of #1342

Remove the baby blueish row color from table rows and add more whitespace into the table cells.
Adjusts the dashboard and sitemap as well so they fit to the new table style.

Screenshots

alchemy cms - new dashboard

alchemy cms - new sitemap

alchemy cms - new users

alchemy cms - new files

@tvdeyen tvdeyen force-pushed the new-table-style branch 2 times, most recently from 20f20b4 to fc6f724 Compare January 16, 2018 11:25
@mamhoff
Copy link
Contributor

mamhoff commented Jan 16, 2018

I like the new table styles, and am hoping for a lighter background color so that tables are better distinguished from the background. But in the spirit of iterative improvement: Let's merge this!

Remove the baby blueish table row color and add more whitespace into the
table cells.
This color is used for form hints and table row hover color. Slightly remove some brightness to not hurt the eye.
Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My previous approval was just a comment, was it not?

@tvdeyen tvdeyen merged commit bc1054a into AlchemyCMS:master Jan 18, 2018
@tvdeyen tvdeyen deleted the new-table-style branch January 18, 2018 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants