Use headless chrome for feature tests #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This records screenshots if errors in feature specs happen. Very useful debugging tool.
This enables us actually testing the select2 selects in feature specs.
Former we were using the hidden select.
tvdeyen
force-pushed
the
headless-chrome
branch
from
48232b9 to
e240247
Compare
Merged
tvdeyen
force-pushed
the
headless-chrome
branch
2 times, most recently
from
185bac6 to
afb4abe
Compare
tvdeyen
force-pushed
the
headless-chrome
branch
from
afb4abe to
097ea9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhantomJS was abondoned by the author and does not support modern javascript and css.
By switching to headless Chrome we test the features in real browser instead.