Remove translations provided by ActiveModel #1354
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alchemy defines several translations that are already defined by ActiveModel. One of these, the "confirmation" translation, is actually incorrect.
As of Rails 5, ActiveModel includes an "%{attribute}" variable reference in the translation, whereas Alchemy's copy simply has the word "confirmation." This results in poorly worded confirmation validation error messages.
For example, with a model defined this way:
If the user doesn't provide a matching password confirmation, the validation error is:
"Password Confirmation doesn't match confirmation"
Whereas using the Rails 5 translation with the embedded "%{attribute}" variable gives:
"Password Confirmation doesn't match Password"
Which makes a whole lot more sense.
I've opted to simply remove the Alchemy translations entirely since these are already defined/provided by ActiveModel and there is really no need to redefine them again in Alchemy's translation file.