Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct scss typo #1388

Merged
merged 3 commits into from
Mar 12, 2018
Merged

correct scss typo #1388

merged 3 commits into from
Mar 12, 2018

Conversation

oniram88
Copy link
Contributor

@oniram88 oniram88 commented Mar 9, 2018

No description provided.

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Could you please explain why you also changed the upgrader note from past to present?

@@ -16,7 +16,7 @@ def alchemy_4_1_todos
Changed tagging provider to Gutentag
------------------------------------

The automatic updater that just ran updated all existing `acts_as_taggable_on_migrations`,
The automatic updater that just run updated all existing `acts_as_taggable_on_migrations`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to change that. This is the note that gets displayed after the upgrader ran.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I must return to school for a better English...sorry!

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tvdeyen tvdeyen merged commit 849f1b4 into AlchemyCMS:master Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants