-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable page publish/view page buttons according to published_at #1498
Disable page publish/view page buttons according to published_at #1498
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that, but think we can improve a little bit.
Also, please create two commits: one for moving the button the other one for changing its behavior.
Ok I will extract moving the button to another PR. |
@westonganger no need to. A commit in this PR is fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still I think we should not disable the publish button.
Ok this should be up to snuff now. |
I was annoyed how the View Page button would allow you to click and get a page error when the page was not published. I would have much rather this button been disabled.