Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Autogenerate nestable elements #1513

Merged
merged 10 commits into from
Nov 11, 2018
Merged

Feature: Autogenerate nestable elements #1513

merged 10 commits into from
Nov 11, 2018

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Nov 5, 2018

What is this pull request for?

You can now pass nestable element names to an elements definition

- name: slider
  nestable_elements:
    - slide
  autogenerate:
    - slide

Notable changes

Includes refactorings for several element and content factory methods

  • Alchemy::Content.build is now Alchemy::Content.new
  • Alchemy::Content.create_from_scratch is now Alchemy::Content.create
  • Alchemy::Element.new_from_scratch is now Alchemy::Element.new
  • Alchemy::Element.create_from_scratch is now Alchemy::Element.create
  • Alchemy::Page#do_not_autogenerate is now Alchemy::Page#autogenerate_elements
  • Alchemy::Element#create_contents_after_create is now Alchemy::Element#autogenerate_contents

tvdeyen added 10 commits October 31, 2018 21:41
@tvdeyen
Rename Page#do_not_autogenerate
5ae758c 
Rename `Page#do_not_autogenerate` into `Page#autogenerate_elements` and negate the default from `do_not_autogenerate = false` to `autogenerate_elements = true`.

Much easier to reason about.
@tvdeyen
Rename Element#create_contents_after_create
3badb84 
Rename `Element#create_contents_after_create` to `Element#autogenerate_contents` for consistency.
@tvdeyen
Rename Element.new_from_scratch into Element.new
698febb
@tvdeyen
Remove the create content from essence type feature
5558f59 
This was solely meant for creating pictures from the picture gallery that we recently replaced by nestable elements.
@tvdeyen
Optimize Alchemy::Content.definitions
e0d2e09 
One array is better than three arrays.
@tvdeyen
Remove spring from development gems
ebd31c8
@tvdeyen
Install Bootsnap on test and dev machines
b1da55c
@tvdeyen
Rename Content#create_from_scratch into create
1216fff 
Rename Content#create_from_scratch into create and make it more consistent to Rails behavior.
@tvdeyen
Give capybara more time to find dialog in attachment spec
d621ec5
@tvdeyen
Feature: Autogenerate nestable elements
a2be9ae 
You can now pass nestable element names to an elements definition

    - name: slider
      nestable_elements:
        - slide
      autogenerate:
        - slide
@tvdeyen tvdeyen merged commit da86e77 into AlchemyCMS:master Nov 11, 2018
@tvdeyen tvdeyen deleted the nestable-elements-autogenerate branch November 11, 2018 22:48
@tvdeyen tvdeyen added this to the 4.2 milestone Jan 26, 2019
tvdeyen added a commit to tvdeyen/alchemy_cms that referenced this pull request Mar 29, 2019
@tvdeyen
v4.2.0.rc1
659fa03 
- Use element name local in generators [AlchemyCMS#1556](AlchemyCMS#1556) ([tvdeyen](https://github.com/tvdeyen))
- Remove invalid bytecode handler [AlchemyCMS#1555](AlchemyCMS#1555) ([tvdeyen](https://github.com/tvdeyen))
- Separate render element calls [AlchemyCMS#1554](AlchemyCMS#1554) ([tvdeyen](https://github.com/tvdeyen))
- Expose the element into partials as local object [AlchemyCMS#1553](AlchemyCMS#1553) ([tvdeyen](https://github.com/tvdeyen))
- Allow admins to switch all languages [AlchemyCMS#1552](AlchemyCMS#1552) ([tvdeyen](https://github.com/tvdeyen))
- Raise targeted Ruby version to 2.3 [AlchemyCMS#1545](AlchemyCMS#1545) ([tvdeyen](https://github.com/tvdeyen))
- Introduces an Elements finder class [AlchemyCMS#1544](AlchemyCMS#1544) ([tvdeyen](https://github.com/tvdeyen))
- Fixate sqlite dep for bug fix [AlchemyCMS#1543](AlchemyCMS#1543) ([tvdeyen](https://github.com/tvdeyen))
- Upgrade shoulda-matchers to version 4.0.0 [AlchemyCMS#1542](AlchemyCMS#1542) ([depfu](https://github.com/apps/depfu))
- Upgrade factory_bot_rails to version 5.0.1 [AlchemyCMS#1540](AlchemyCMS#1540) ([depfu](https://github.com/apps/depfu))
- Use Flatpickr as Datepicker [AlchemyCMS#1533](AlchemyCMS#1533) ([mamhoff](https://github.com/mamhoff))
-  Use system tests over feature specs [AlchemyCMS#1528](AlchemyCMS#1528) ([tvdeyen](https://github.com/tvdeyen))
- Flexible width for admin navigation entry labels [AlchemyCMS#1527](AlchemyCMS#1527) ([tvdeyen](https://github.com/tvdeyen))
- Responsive elements window and sidebar [AlchemyCMS#1519](AlchemyCMS#1519) ([tvdeyen](https://github.com/tvdeyen))
- Change element eye icon on public state [AlchemyCMS#1517](AlchemyCMS#1517) ([oniram88](https://github.com/oniram88))
- Maximize element window if Tinymce is fullscreen [AlchemyCMS#1515](AlchemyCMS#1515) ([tvdeyen](https://github.com/tvdeyen))
- Remove cells in favour of fixed elements [AlchemyCMS#1514](AlchemyCMS#1514) ([tvdeyen](https://github.com/tvdeyen))
- Feature: Autogenerate nestable elements [AlchemyCMS#1513](AlchemyCMS#1513) ([tvdeyen](https://github.com/tvdeyen))
- Allow "data" key for module navigations [AlchemyCMS#1512](AlchemyCMS#1512) ([mamhoff](https://github.com/mamhoff))
- Allow to define layout for page previews [AlchemyCMS#1500](AlchemyCMS#1500) ([westonganger](https://github.com/westonganger))
- Fix capitalization for login/logout/leave [AlchemyCMS#1497](AlchemyCMS#1497) ([westonganger](https://github.com/westonganger))
- Verify controller keys within `register_module` [AlchemyCMS#1495](AlchemyCMS#1495) ([westonganger](https://github.com/westonganger))
- Update bundled Tinymce to 4.8.3 [AlchemyCMS#1491](AlchemyCMS#1491) ([tvdeyen](https://github.com/tvdeyen))
- Use dynamic attributes in factories [AlchemyCMS#1484](AlchemyCMS#1484) ([tvdeyen](https://github.com/tvdeyen))
- Migrating to active_model_serializers ~> 0.10.0 [AlchemyCMS#1478](AlchemyCMS#1478) ([pmashchak](https://github.com/pmashchak))
- Replace picture galleries with nestable elements [AlchemyCMS#1358](AlchemyCMS#1358) ([tvdeyen](https://github.com/tvdeyen))
- Add a compact nested element style [AlchemyCMS#1357](AlchemyCMS#1357) by [tvdeyen](https://github.com/tvdeyen)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs changelog
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
1 participant
@tvdeyen