Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add default styling for number inputs #1598

Merged
merged 1 commit into from
Aug 15, 2019
Merged

add default styling for number inputs #1598

merged 1 commit into from
Aug 15, 2019

Conversation

alexanderadam
Copy link
Contributor

What is this pull request for?

This simple PR just adds the rule for having styled input fields with number type.

Screenshots (remove if none)

before:
Screenshot_20190808_103810

after:
Screenshot_20190808_103741

tvdeyen
tvdeyen approved these changes Aug 8, 2019
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@tvdeyen
Copy link
Member

tvdeyen commented Aug 8, 2019

Spec failures are not related

@tvdeyen tvdeyen added this to the 4.3 milestone Aug 8, 2019
@tvdeyen
Copy link
Member

tvdeyen commented Aug 8, 2019

@alexanderadam would you please rebase with latest master now that #1601 has been merged? This will fix the builds. Thanks.

@tvdeyen tvdeyen merged commit 70cb77b into AlchemyCMS:master Aug 15, 2019
@tvdeyen
Copy link
Member

tvdeyen commented Aug 15, 2019

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@alexanderadam @tvdeyen