Add ContentEditor decorator #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
add-content-editor-decorator
branch
3 times, most recently
from
325d594 to
d4f9983
Compare
Speeds up element content editor rendering by making use of Rails collection partial rendering. Also holds all presenter methods from Content model.
tvdeyen
force-pushed
the
add-content-editor-decorator
branch
from
d4f9983 to
be537fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Adds a ContentEditor decorator so we can make use of Rails collection partial rendering for essence editor partials.
Notable changes
This make it necessary to replace the local
contentvariable with the essence editor partial name. So, for example theEssenceTexteditor partial now has anessence_text_editorvariable instead of acontentvariable. This variable holds theAlchemy::ContentEditorinstance which is a simple delegator to theAlchemy::Contentinstance.