Convert page editing user methods into AR relations #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to proper eager load the user class.
tvdeyen
force-pushed
the
relate-page-editing-users
branch
from
1d9462f to
24bef77
Compare
|
Code Climate has analyzed commit 24bef77 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 92.0% (0.0% change). View more on Code Climate. |
tvdeyen
added a commit
that referenced
this pull request
Jan 6, 2020
- Use contents settings for size in EssencePicture#picture_url [#1703](#1703) ([tvdeyen](https://github.com/tvdeyen)) - Remove title tag from preview elements [#1701](#1701) ([tvdeyen](https://github.com/tvdeyen)) - Remove custom JS logging [#1700](#1700) ([tvdeyen](https://github.com/tvdeyen)) - Remove demo locale files [#1699](#1699) ([tvdeyen](https://github.com/tvdeyen)) - Use alchemyPageSelect for Node page select [#1698](#1698) ([tvdeyen](https://github.com/tvdeyen)) - Cache menu partials [#1697](#1697) ([tvdeyen](https://github.com/tvdeyen)) - Update page tree to menu nodes Rake task [#1696](#1696) ([tvdeyen](https://github.com/tvdeyen)) - Validate nodes name if page is absent [#1695](#1695) ([tvdeyen](https://github.com/tvdeyen)) - Update the application layout installer template [#1691](#1691) ([tvdeyen](https://github.com/tvdeyen)) - Update note about missing user class [#1690](#1690) ([tvdeyen](https://github.com/tvdeyen)) - Use a Sprockets 3/4 manifest file [#1689](#1689) ([tvdeyen](https://github.com/tvdeyen)) - Use select2 for internal page link in link overlay [#1685](#1685) ([tvdeyen](https://github.com/tvdeyen)) - Do not consider nested elements "orphaned" [#1684](#1684) ([mamhoff](https://github.com/mamhoff)) - Destroy page-dependent elements [#1683](#1683) ([mamhoff](https://github.com/mamhoff)) - Add anchor link tab to link overlay [#1682](#1682) ([tvdeyen](https://github.com/tvdeyen)) - Ensure the apt/cache folder exists while installing [#1678](#1678) ([tvdeyen](https://github.com/tvdeyen)) - Cache apt packages between CI runs [#1677](#1677) ([tvdeyen](https://github.com/tvdeyen)) - Use select2 with AJAX search for essence page select [#1675](#1675) ([tvdeyen](https://github.com/tvdeyen)) - Eager load associated records [#1674](#1674) ([tvdeyen](https://github.com/tvdeyen)) - Add support for testing with multiple Rails versions [#1673](#1673) ([tvdeyen](https://github.com/tvdeyen)) - Page api pagination [#1672](#1672) ([tvdeyen](https://github.com/tvdeyen)) - Adjust select2 loading-more indicator [#1671](#1671) ([tvdeyen](https://github.com/tvdeyen)) - Test support fixes [#1669](#1669) ([tvdeyen](https://github.com/tvdeyen)) - Build fixes [#1668](#1668) ([tvdeyen](https://github.com/tvdeyen)) - Add Menus [#1667](#1667) ([tvdeyen](https://github.com/tvdeyen)) - Add a label component [#1666](#1666) ([tvdeyen](https://github.com/tvdeyen)) - Run bundle install on CI even if cache hits [#1665](#1665) ([tvdeyen](https://github.com/tvdeyen)) - Moves switch_language method into languages_controller. [#1664](#1664) ([tvdeyen](https://github.com/tvdeyen)) - Cache gems between CI runs [#1663](#1663) ([tvdeyen](https://github.com/tvdeyen)) - Remove production gems from local Gemfile [#1662](#1662) ([tvdeyen](https://github.com/tvdeyen)) - Touch contents updated_at column in pure SQL [#1661](#1661) ([tvdeyen](https://github.com/tvdeyen)) - Convert page editing user methods into AR relations [#1658](#1658) ([tvdeyen](https://github.com/tvdeyen)) - Ensure the admin locale is only set by available locales [#1655](#1655) ([tvdeyen](https://github.com/tvdeyen)) - Add a GitHub actions ci.yml [#1654](#1654) ([tvdeyen](https://github.com/tvdeyen)) - Adjust install generator to latest changes [#1649](#1649) ([tvdeyen](https://github.com/tvdeyen)) - Deprecate _view suffix of element views [#1648](#1648) ([tvdeyen](https://github.com/tvdeyen)) - Add a configurable logout method (default: delete) [#1647](#1647) ([delphaber](https://github.com/delphaber)) - Deprecate render_essence helpers [#1644](#1644) ([tvdeyen](https://github.com/tvdeyen)) - Deprecate element editors [#1643](#1643) ([tvdeyen](https://github.com/tvdeyen)) - Deprecate local options in essence editors [#1642](#1642) ([tvdeyen](https://github.com/tvdeyen)) - Ensure the EssencePage id regexp matches only numbers [#1641](#1641) ([tvdeyen](https://github.com/tvdeyen)) - Use EssencePage in contact forms [#1640](#1640) ([tvdeyen](https://github.com/tvdeyen)) - Add Alchemy::EssencePage [#1639](#1639) ([tvdeyen](https://github.com/tvdeyen)) - FEAT: Render message and warnings in element editor [#1637](#1637) ([tvdeyen](https://github.com/tvdeyen)) - Tackle Rails 6 deprecations [#1636](#1636) ([tvdeyen](https://github.com/tvdeyen)) - Preload assets in tests [#1635](#1635) ([tvdeyen](https://github.com/tvdeyen)) - Allow acts-as-list 1.0 [#1634](#1634) ([tvdeyen](https://github.com/tvdeyen)) - Add Sprockets manifest file to dummy app [#1632](#1632) ([tvdeyen](https://github.com/tvdeyen)) - Master now tracks 4.4.0.alpha [#1627](#1627) ([tvdeyen](https://github.com/tvdeyen)) - Fix Cell Migration to maintain positions [#1625](#1625) ([mamhoff](https://github.com/mamhoff)) - Cell Upgrader: Match quotation marks in cell name string [#1624](#1624) ([mamhoff](https://github.com/mamhoff)) - Cell Migrator: Maintain element order in fixed elements [#1623](#1623) ([mamhoff](https://github.com/mamhoff)) - Enhance cells upgrader to deal with render_elements from_page: x [#1622](#1622) ([mamhoff](https://github.com/mamhoff))
Merged
tvdeyen
added a commit
that referenced
this pull request
Jan 6, 2020
- Use contents settings for size in EssencePicture#picture_url [#1703](#1703) ([tvdeyen](https://github.com/tvdeyen)) - Remove title tag from preview elements [#1701](#1701) ([tvdeyen](https://github.com/tvdeyen)) - Remove custom JS logging [#1700](#1700) ([tvdeyen](https://github.com/tvdeyen)) - Remove demo locale files [#1699](#1699) ([tvdeyen](https://github.com/tvdeyen)) - Use alchemyPageSelect for Node page select [#1698](#1698) ([tvdeyen](https://github.com/tvdeyen)) - Cache menu partials [#1697](#1697) ([tvdeyen](https://github.com/tvdeyen)) - Update page tree to menu nodes Rake task [#1696](#1696) ([tvdeyen](https://github.com/tvdeyen)) - Validate nodes name if page is absent [#1695](#1695) ([tvdeyen](https://github.com/tvdeyen)) - Update the application layout installer template [#1691](#1691) ([tvdeyen](https://github.com/tvdeyen)) - Update note about missing user class [#1690](#1690) ([tvdeyen](https://github.com/tvdeyen)) - Use a Sprockets 3/4 manifest file [#1689](#1689) ([tvdeyen](https://github.com/tvdeyen)) - Use select2 for internal page link in link overlay [#1685](#1685) ([tvdeyen](https://github.com/tvdeyen)) - Do not consider nested elements "orphaned" [#1684](#1684) ([mamhoff](https://github.com/mamhoff)) - Destroy page-dependent elements [#1683](#1683) ([mamhoff](https://github.com/mamhoff)) - Add anchor link tab to link overlay [#1682](#1682) ([tvdeyen](https://github.com/tvdeyen)) - Ensure the apt/cache folder exists while installing [#1678](#1678) ([tvdeyen](https://github.com/tvdeyen)) - Cache apt packages between CI runs [#1677](#1677) ([tvdeyen](https://github.com/tvdeyen)) - Use select2 with AJAX search for essence page select [#1675](#1675) ([tvdeyen](https://github.com/tvdeyen)) - Eager load associated records [#1674](#1674) ([tvdeyen](https://github.com/tvdeyen)) - Add support for testing with multiple Rails versions [#1673](#1673) ([tvdeyen](https://github.com/tvdeyen)) - Page api pagination [#1672](#1672) ([tvdeyen](https://github.com/tvdeyen)) - Adjust select2 loading-more indicator [#1671](#1671) ([tvdeyen](https://github.com/tvdeyen)) - Test support fixes [#1669](#1669) ([tvdeyen](https://github.com/tvdeyen)) - Build fixes [#1668](#1668) ([tvdeyen](https://github.com/tvdeyen)) - Add Menus [#1667](#1667) ([tvdeyen](https://github.com/tvdeyen)) - Add a label component [#1666](#1666) ([tvdeyen](https://github.com/tvdeyen)) - Run bundle install on CI even if cache hits [#1665](#1665) ([tvdeyen](https://github.com/tvdeyen)) - Moves switch_language method into languages_controller. [#1664](#1664) ([tvdeyen](https://github.com/tvdeyen)) - Cache gems between CI runs [#1663](#1663) ([tvdeyen](https://github.com/tvdeyen)) - Remove production gems from local Gemfile [#1662](#1662) ([tvdeyen](https://github.com/tvdeyen)) - Touch contents updated_at column in pure SQL [#1661](#1661) ([tvdeyen](https://github.com/tvdeyen)) - Convert page editing user methods into AR relations [#1658](#1658) ([tvdeyen](https://github.com/tvdeyen)) - Ensure the admin locale is only set by available locales [#1655](#1655) ([tvdeyen](https://github.com/tvdeyen)) - Add a GitHub actions ci.yml [#1654](#1654) ([tvdeyen](https://github.com/tvdeyen)) - Adjust install generator to latest changes [#1649](#1649) ([tvdeyen](https://github.com/tvdeyen)) - Deprecate _view suffix of element views [#1648](#1648) ([tvdeyen](https://github.com/tvdeyen)) - Add a configurable logout method (default: delete) [#1647](#1647) ([delphaber](https://github.com/delphaber)) - Deprecate render_essence helpers [#1644](#1644) ([tvdeyen](https://github.com/tvdeyen)) - Deprecate element editors [#1643](#1643) ([tvdeyen](https://github.com/tvdeyen)) - Deprecate local options in essence editors [#1642](#1642) ([tvdeyen](https://github.com/tvdeyen)) - Ensure the EssencePage id regexp matches only numbers [#1641](#1641) ([tvdeyen](https://github.com/tvdeyen)) - Use EssencePage in contact forms [#1640](#1640) ([tvdeyen](https://github.com/tvdeyen)) - Add Alchemy::EssencePage [#1639](#1639) ([tvdeyen](https://github.com/tvdeyen)) - FEAT: Render message and warnings in element editor [#1637](#1637) ([tvdeyen](https://github.com/tvdeyen)) - Tackle Rails 6 deprecations [#1636](#1636) ([tvdeyen](https://github.com/tvdeyen)) - Preload assets in tests [#1635](#1635) ([tvdeyen](https://github.com/tvdeyen)) - Allow acts-as-list 1.0 [#1634](#1634) ([tvdeyen](https://github.com/tvdeyen)) - Add Sprockets manifest file to dummy app [#1632](#1632) ([tvdeyen](https://github.com/tvdeyen)) - Master now tracks 4.4.0.alpha [#1627](#1627) ([tvdeyen](https://github.com/tvdeyen)) - Fix Cell Migration to maintain positions [#1625](#1625) ([mamhoff](https://github.com/mamhoff)) - Cell Upgrader: Match quotation marks in cell name string [#1624](#1624) ([mamhoff](https://github.com/mamhoff)) - Cell Migrator: Maintain element order in fixed elements [#1623](#1623) ([mamhoff](https://github.com/mamhoff)) - Enhance cells upgrader to deal with render_elements from_page: x [#1622](#1622) ([mamhoff](https://github.com/mamhoff))
tvdeyen
added a commit
to tvdeyen/alchemy_cms
that referenced
this pull request
Jan 7, 2020
After we merged 24bef77 we force Rails to connect to the database whenever we eager load the page class. Instead we introduce a config so users with Userclass primary keys different than :id can set it. Refs AlchemyCMS#710 Refs AlchemyCMS#711 Refs AlchemyCMS#1658
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to proper eager load the user class.