Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI builds with Sprockets 3.7.2 #1731

Merged
merged 2 commits into from
Feb 24, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use Sprockets 3.7.2 on linux build servers
There is a serious unfixed bug in sassc-ruby that causes
issues when used with Sprockets 4.
tvdeyen committed Feb 24, 2020

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tvdeyen Thomas von Deyen
commit c7e8b34ea41cac5d04a2d4a1f9318eccc3e4a525
4 changes: 3 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
@@ -12,7 +12,9 @@ gem 'mysql2', '~> 0.5.1' if ENV['DB'] == 'mysql'
gem 'pg', '~> 1.0' if ENV['DB'] == 'postgresql'

group :development, :test do
unless ENV['CI']
if ENV['CI']
gem 'sprockets', '< 4.0' # Sprockets 4 has serious issues with libsass on Linux machines
else
gem 'launchy'
gem 'annotate'
gem 'bumpy'
1 change: 0 additions & 1 deletion spec/rails_helper.rb
Original file line number Diff line number Diff line change
@@ -93,7 +93,6 @@
# towards the timing of the first feature spec.
start = Time.now
puts "Preloading assets."
Rails.application.assets.cache.clear
Rails.application.precompiled_assets
puts "Done in #{(Time.now - start).round(2)}s"
end