Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Remove page visible #1839

Closed

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented May 19, 2020

What is this pull request for?

Remove Page#visible and simplify the url name generation

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen added this to the 5.0 milestone May 19, 2020
@tvdeyen tvdeyen requested a review from mamhoff May 19, 2020 07:33
@tvdeyen tvdeyen changed the title Allow page visible toggle (master) WIP Remove page visible May 21, 2020
@tvdeyen tvdeyen removed the request for review from mamhoff May 21, 2020 21:47
@tvdeyen tvdeyen self-assigned this May 21, 2020
@tvdeyen tvdeyen marked this pull request as draft May 25, 2020 21:44
tvdeyen added 5 commits May 27, 2020 11:23
We should only check if any menus are present to attach a page to for the same language.
The Page#visible status is used to build the urlname of child pages. If a page is attached to a menu we should still be able to toggle that flag.
@tvdeyen tvdeyen force-pushed the allow-page-visible-toggle-master branch from 1fb325d to 312de64 Compare May 27, 2020 09:23
@tvdeyen tvdeyen closed this Jun 2, 2020
@tvdeyen tvdeyen deleted the allow-page-visible-toggle-master branch June 2, 2020 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant