Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not add id attributes to hidden fields in search and filters #1899

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Do not add id attributes to hidden fields in search and filters #1899

merged 1 commit into from
Jul 17, 2020

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jul 15, 2020

What is this pull request for?

Do not add id attributes to hidden fields in search and filters.

Those ids may collide with actual fields making the JS on them not work.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen added this to the 5.1 milestone Jul 15, 2020
@tvdeyen tvdeyen force-pushed the remove-ids-from-hidden-fields branch from 2bb3525 to ef5bc3a Compare July 17, 2020 06:22
@tvdeyen tvdeyen merged commit 0b7cc38 into AlchemyCMS:master Jul 17, 2020
@tvdeyen tvdeyen deleted the remove-ids-from-hidden-fields branch July 17, 2020 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
1 participant
@tvdeyen